[FIX] Content Style: delete image from IRSS container (47832)#11607
Open
chfsx wants to merge 1 commit into
Open
[FIX] Content Style: delete image from IRSS container (47832)#11607chfsx wants to merge 1 commit into
chfsx wants to merge 1 commit into
Conversation
Images of content styles are stored in the IRSS container since the IRSS migration. Upload and listing already use IRSS, but ImageFileRepo::deleteImageByFilename() still removed the file from the legacy web directory sty/sty_<id>/images, which does not exist for migrated styles. The delete action therefore had no effect. Delete the entry from the IRSS container via IRSSWrapper::removePathFromContainer() and keep the legacy delete as a fallback for non-migrated styles. Mantis: 47832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageFileRepo::deleteImageByFilename()still removed the file from the legacy web directorysty/sty_<id>/images, which does not exist for migrated styles — so the delete button in the Style Editor had no effect.IRSSWrapper::removePathFromContainer()and keeps the legacy delete as a fallback for non-migrated styles.Mantis: #47832
Test plan
sty/sty_<id>/imagesdirectory and confirm deletion still works there